perf: resource cleanup, don't start module reloader in run mode #3656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't start module autoreloader in run mode, since it's not needed; this should stem a memory leak in run mode. Still need to see if the reloader is leaking memory in edit mode. Cleanup some threads in both run and edit mode on kernel shutdown * Shut down the module watcher on kernel shutdown * Stop the standard io forwarding threads
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
mscolnick
approved these changes
Feb 2, 2025
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.10.20-dev16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't start module autoreloader in run mode, since it's not needed; this should stem a memory leak in run mode. Still need to see if the reloader is leaking memory in edit mode. Hopefully improves #3623.
Cleanup some threads in on kernel shutdown, which should improve edit mode performance when using a long-lived
marimo editserver: