Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: database GUI to create connections #3737

Merged
merged 4 commits into from
Feb 11, 2025
Merged

feat: database GUI to create connections #3737

merged 4 commits into from
Feb 11, 2025

Conversation

mscolnick
Copy link
Contributor

@mscolnick mscolnick commented Feb 9, 2025

Schema-driven UI for creating databases. On create, these will be added as a cell in the top. Will also let user's pick their ORM/query-engine of choice.

Screenshot 2025-02-10 at 8 02 57 PM Screenshot 2025-02-10 at 8 03 12 PM Screenshot 2025-02-09 at 5 03 53 PM

Copy link

vercel bot commented Feb 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 2:20am
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 2:20am

@mscolnick mscolnick marked this pull request as draft February 9, 2025 22:20
@mscolnick mscolnick changed the title feat: database GUI to create connections [wip] feat: database GUI to create connections Feb 9, 2025
@mscolnick mscolnick changed the title [wip] feat: database GUI to create connections feat: database GUI to create connections Feb 11, 2025
@mscolnick mscolnick marked this pull request as ready for review February 11, 2025 01:06
@Light2Dark
Copy link
Collaborator

nicee!

I don't think this will work with snowflake just yet. Snowflake is quite finnicky. This is how I set it up

pip install snowflake-sqlalchemy
from snowflake.sqlalchemy import URL
import sqlalchemy as sa

engine = sa.create_engine(
    URL(
        account="JJIYDVS-WP83405",
        password="#####",
        user="SHAHMIR",
        database="SNOWFLAKE_SAMPLE_DATA",
        # warehouse="COMPUTE_WH",
        role="ACCOUNTADMIN",
    )
    # "snowflake://{username}:{password}@{account_identifier}/{database}/{schema}?warehouse={warehouse}&role={rolename}"
)

this is more for future improvement, the PR is fine:
image

  • maybe we could make the 'add database' more visible, maybe just put it at the bottom as if it were empty panel?
  • make sqlalchemy the preferred / first selected option (less deps)

@mscolnick
Copy link
Contributor Author

mscolnick commented Feb 11, 2025

@Light2Dark, thanks for the snippets.

and i like your suggestions, ill incorporate them in this PR.

EDIT: im actually going to leave the second suggestion making the plus button more visible, for now. we can improve it, but 1) touches some of your existing code and 2) i don't think it will be used all that often. its more prominent in the zero state.

Screenshot 2025-02-10 at 9 03 38 PM

@mscolnick mscolnick merged commit 10f96fd into main Feb 11, 2025
23 checks passed
@mscolnick mscolnick deleted the ms/db-gui branch February 11, 2025 03:00
Copy link

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.11.3-dev3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants