fix: semicolon supression #3830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
for more information, see https://pre-commit.ci
|
Oh wait, I think tests will fail, the asserts are wrong |
|
@dmadisetti, tests are in bad shape. if you see your test pass, feel free to merge |
|
@mscolnick my tests pass, but lacking permissions to force (which is fine, just a heads up) tests/_ast/test_compiler.py::TestSemicolon::test_return PASSED [ 6%]
tests/_ast/test_compiler.py::TestSemicolon::test_return_suppressed PASSED [ 6%]
tests/_ast/test_compiler.py::TestSemicolon::test_return_last PASSED [ 6%]
tests/_ast/test_compiler.py::TestSemicolon::test_return_last_suppressed PASSED [ 6%]
tests/_ast/test_compiler.py::TestSemicolon::test_return_comment PASSED [ 6%]
tests/_ast/test_compiler.py::TestSemicolon::test_return_comment_suppressed PASSED [ 6%]
tests/_ast/test_compiler.py::TestSemicolon::test_return_string_semicolon PASSED [ 6%]
tests/_ast/test_compiler.py::TestSemicolon::test_return_string_semicolon_suppressed PASSED [ 6%] |
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.11.7-dev7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Replaces #3806
🔍 Description of Changes
Resolves #3726
@mscolnick