Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run EMA tasks in EMA screen #27

Merged
merged 4 commits into from
Apr 26, 2024
Merged

Run EMA tasks in EMA screen #27

merged 4 commits into from
Apr 26, 2024

Conversation

mario-bermonti
Copy link
Owner

Description

All EMA as run in random order when the begin button in the EMA screen is pressed.

It required making the runSession service async so we can await it.

These changes introduce 3 challenges that must be addressed in the future:

  1. Errors occur if the EMA task sequence is started by pressing on a notification while already running a manual task.
  2. The EMA screen appears briefly between EMA tasks
  3. The EMA screen appears briefly before moving to the home screen after completing all EMA tasks

Related Issue

Close #26

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🐞 Bug fix (non-breaking change that fixes an issue)
  • 🔧 Maintenance (non-breaking change that improves code)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix
  • 🔐 Improvements to the CI workflow

Checklist

feat: Run EMA tasks in EMA screen

improve: Go to home screen after ema tasks
Necessary when calling runSession outside a button press, e.g.,
runEMATasks
@mario-bermonti mario-bermonti merged commit d7c2cc8 into main Apr 26, 2024
2 checks passed
@mario-bermonti mario-bermonti deleted the mario-bermonti/issue26 branch April 26, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run EMA tasks from EMA screen
1 participant