Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small refactor to reduce LOC and keep code DRY. #53

Merged
merged 14 commits into from
Jun 26, 2023

Conversation

chrispaig3
Copy link
Contributor

@chrispaig3 chrispaig3 commented Jun 21, 2023

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally before submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

Copy link
Owner

@mariocandela mariocandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really appreciate your work ❤️ I will approve it once you remove all comments

main.go Outdated Show resolved Hide resolved
tracer/tracer.go Outdated Show resolved Hide resolved
plugins/openai-gpt.go Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
chrispaig3 and others added 4 commits June 25, 2023 16:38
Co-authored-by: Mario Candela <m4r10.php@gmail.com>
Signed-off-by: Chris  <88049272+V0idMatr1x@users.noreply.github.com>
Co-authored-by: Mario Candela <m4r10.php@gmail.com>
Signed-off-by: Chris  <88049272+V0idMatr1x@users.noreply.github.com>
Co-authored-by: Mario Candela <m4r10.php@gmail.com>
Signed-off-by: Chris  <88049272+V0idMatr1x@users.noreply.github.com>
@chrispaig3
Copy link
Contributor Author

I appreciate your work ❤️ I will approve it once you remove all comments

I appreciate you letting me contribute to your project!
Thank you for your time and the code review!

I hope to make more meaningful contributions in the future 😄

Copy link
Owner

@mariocandela mariocandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For any future changes or ideas, kindly initiate a discussion on the following GitHub page: https://github.com/mariocandela/beelzebub/discussions 😄
Thanks for your time mate

Co-authored-by: Mario Candela <m4r10.php@gmail.com>
Signed-off-by: Chris  <88049272+V0idMatr1x@users.noreply.github.com>
@chrispaig3
Copy link
Contributor Author

For any future changes or ideas, kindly initiate a discussion on the following GitHub page: https://github.com/mariocandela/beelzebub/discussions 😄 Thanks for your time mate

Will do! You are very welcome!

Copy link
Owner

@mariocandela mariocandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mariocandela mariocandela merged commit 9670cf0 into mariocandela:main Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants