Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: orders and moderator implementation #18

Merged
merged 64 commits into from
Jun 23, 2024
Merged

feat: orders and moderator implementation #18

merged 64 commits into from
Jun 23, 2024

Conversation

mariocosenza
Copy link
Owner

orders and moderator implementation

Copy link

Qodana for JVM

1 new problem were found

Inspection name Severity Problems
'if' statement with identical branches ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com


try {
Gson gson = new Gson();
map = gson.fromJson(req.getReader(), mapType);

Check notice

Code scanning / SonarCloud

Exceptions should not be thrown from servlet methods Low

Handle the following exceptions that could be thrown by "fromJson": JsonIOException, JsonSyntaxException. See more on SonarCloud
try {
resp.sendError(HttpServletResponse.SC_FORBIDDEN);
} catch (IOException e) {
throw new RuntimeException(e);

Check notice

Code scanning / SonarCloud

Exceptions should not be thrown from servlet methods Low

Handle the "RuntimeException" thrown here in a "try/catch" block. See more on SonarCloud
# Conflicts:
#	src/main/java/it/savoreco/controller/OrdersServlet.java
#	src/main/java/it/savoreco/model/entity/Purchase.java
try {
response.sendError(HttpServletResponse.SC_FORBIDDEN);
} catch (IOException e) {
throw new RuntimeException(e);

Check notice

Code scanning / SonarCloud

Exceptions should not be thrown from servlet methods Low

Handle the "RuntimeException" thrown here in a "try/catch" block. See more on SonarCloud
Copy link

sonarcloud bot commented Jun 23, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
C Reliability Rating on New Code (required ≥ A)
B Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@mariocosenza mariocosenza merged commit cd32b01 into main Jun 23, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants