-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect display on FF 66a with "Minimum font size" set #39
Comments
Thanks for reporting @pabuisson! I use FF 64 and can not reproduce the issue either. Test with FF Nightly pending. |
Using FF 66.0a1 (2019-01-11) I could not reproduce the issue. Are all the svg images on Darren's post affected for you? |
Yes all images. It might be an issue with an addon of mine, I'll try to find what could lead to this. Maybe in a few hours though. I'll keep you posted. |
Found it! It was not related to any addon. Actually, in my Firefox, I got the "Minimum font size" setting set to 9. That's what's making the SVG looks like the screenshot of the first post. If I set "Minimum font size" to "None", then I get the expected result : I checked my chrome-based browsers, they also have this "Minimum font size" setting set to 9 but it has no impact on the SVG rendering. Hope it helped! |
Thank you for the analysis! I'll see what |
This appears to be the current and correct tracking issue in Bugzilla. Sadly there was a whole run of attempts to fix this, which all got backed out due to causing other intermittent regressions: https://bugzilla.mozilla.org/show_bug.cgi?id=935056 But it does contain some info on what causes the regression, essentially Firefox applying minimum size clamping too early in SVG text size computation. E.g. FF applies minimum size clamping to "5px" in the SVG file's coordinate system, not the actual on-screen rendered text size due factoring in the SVG viewport. That suggests a possible solution where manipulating/scaling the coordinate system in the generated SVGs, but leaving the final on-screen size the same, may produce a fix. |
For posterity's sake, I also found this comment on a nearly identical Chromium issue, before a fix was landed there: https://bugs.chromium.org/p/chromium/issues/detail?id=232332#c11
Unfortunately, that attribute appears to have zero effect on the Firefox bug. I manually edited the |
See also this SO post on this exact issue. |
Thx for the |
Hey,
Following up on this. Here's what I get when I display a term SVG in Firefox 66 (nightly), on macOS :
The image is animated alright, but font size and spacing and everything seems broken. Same svg is displayed nicely on the same machine with a blink-based browser or an old FF-56.
I tried to turn off every ad-blocking and tracker-blocking and content-blocking addon and it's still the same.
The text was updated successfully, but these errors were encountered: