Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add number_with_commas to NumberFormat enum #216

Merged
merged 1 commit into from
May 2, 2023

Conversation

DJafari
Copy link
Contributor

@DJafari DJafari commented May 1, 2023

for my database i have a column with number_with_commas number format

"Count": {
	"id": "%3Dk%60U",
	"name": "Count",
	"type": "number",
	"number": {
		"format": "number_with_commas"
	}
},

i getting this exception :

"number_with_commas" is not a valid backing value for enum "Notion\Databases\Properties\NumberFormat"

this PR solve this bug

@mariosimao mariosimao merged commit 45a67ea into mariosimao:main May 2, 2023
@mariosimao
Copy link
Owner

Released on version 1.8.0.

@mariosimao mariosimao self-assigned this Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants