Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(page): properties with empty values #260

Merged
merged 3 commits into from
Jun 27, 2023
Merged

feat(page): properties with empty values #260

merged 3 commits into from
Jun 27, 2023

Conversation

mariosimao
Copy link
Owner

Closes #257

@mariosimao mariosimao self-assigned this Jun 27, 2023
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #260 (2ea93b2) into main (f546632) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main     #260   +/-   ##
=========================================
  Coverage     99.18%   99.18%           
  Complexity     1319     1319           
=========================================
  Files           158      158           
  Lines          4304     4304           
=========================================
  Hits           4269     4269           
  Misses           35       35           
Impacted Files Coverage Δ
src/Pages/Properties/Date.php 100.00% <100.00%> (ø)
src/Pages/Properties/Email.php 100.00% <100.00%> (ø)
src/Pages/Properties/Number.php 100.00% <100.00%> (ø)
src/Pages/Properties/PhoneNumber.php 100.00% <100.00%> (ø)
src/Pages/Properties/PropertyCollection.php 100.00% <100.00%> (ø)
src/Pages/Properties/RichTextProperty.php 100.00% <100.00%> (ø)
src/Pages/Properties/Select.php 100.00% <100.00%> (ø)
src/Pages/Properties/Url.php 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mariosimao mariosimao merged commit 3abda59 into main Jun 27, 2023
@mariosimao mariosimao deleted the empty-props branch June 27, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Delete page properties
1 participant