Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle empty value for select property #86

Merged
merged 1 commit into from
Jun 22, 2022
Merged

fix: handle empty value for select property #86

merged 1 commit into from
Jun 22, 2022

Conversation

iamalexchip
Copy link
Contributor

If the a select property is empty the

Notion\Pages\Properties\Option::fromArray(): Argument #1 ($array) must be of type array, null given, called in /vendor/mariosimao/notion-sdk-php/src/Pages/Properties/Select.php on line 49

@codecov-commenter
Copy link

Codecov Report

Merging #86 (5876d50) into main (6d79e97) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main      #86   +/-   ##
=========================================
  Coverage     98.84%   98.84%           
  Complexity     1122     1122           
=========================================
  Files           101      101           
  Lines          3632     3632           
=========================================
  Hits           3590     3590           
  Misses           42       42           
Impacted Files Coverage Δ
src/Pages/Properties/Option.php 100.00% <100.00%> (ø)
src/Pages/Properties/Select.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d79e97...5876d50. Read the comment docs.

@mariosimao mariosimao merged commit d32e874 into mariosimao:main Jun 22, 2022
@mariosimao
Copy link
Owner

@iamalexchip thanks for your contribution!

Changes are now available on version 0.5.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants