Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename reading.compass to reading.heading for better "naming things" #18

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

amotl
Copy link
Contributor

@amotl amotl commented Feb 24, 2023

This patch implements the suggestion at #12 (comment):

On a side note: roll and pitch also come from the gyro, don't they? Should we perhaps rename the reading.compass field to reading.heading for the sake of better "naming things"?

@UserMacUseface endorsed this improvement.

@amotl amotl merged commit 4361e68 into main Feb 24, 2023
@amotl amotl deleted the amo/improve-heading branch February 24, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant