Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NMEA0183 telemetry: Emit compass/{heading,pitch,roll} data using $MLHDT and $MLXDR sentences #24

Merged
merged 3 commits into from
Feb 24, 2023

Conversation

amotl
Copy link
Contributor

@amotl amotl commented Feb 24, 2023

At #12 (comment) ff., we discussed the NMEA0183 telemetry sentence format for emitting heading, pitch, and roll values. This patch implements it. An example payload, including multiple sentences, and wind information, is now:

$MLHDT,235.0,T*27
$MLVWR,154.0,L,11.06,N,5.69,M,20.48,K*64
$MLXDR,A,-60.0,D,PTCH#CAL,A,30.0,D,ROLL#CAL*75

@amotl amotl mentioned this pull request Feb 24, 2023
@amotl amotl changed the title NMEA0183 telemetry: Emit compass/{heading,pitch,roll} data using $MLHDT and $MLXDR sentences NMEA0183 telemetry: Emit compass/{heading,pitch,roll} data using $MLHDT and $MLXDR sentences Feb 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2023

Codecov Report

Merging #24 (56d35df) into main (a267ff4) will increase coverage by 0.10%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
+ Coverage   95.17%   95.27%   +0.10%     
==========================================
  Files          14       14              
  Lines         725      741      +16     
==========================================
+ Hits          690      706      +16     
  Misses         35       35              
Flag Coverage Δ
unittests 95.27% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
calypso_anemometer/telemetry/network.py 86.66% <100.00%> (ø)
calypso_anemometer/telemetry/nmea0183.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@amotl amotl requested a review from UserMacUseface February 24, 2023 21:37
@amotl amotl merged commit 73fd197 into main Feb 24, 2023
@amotl amotl deleted the amo/compass-to-nmea branch February 24, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants