Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coding conventions #102

Merged
merged 2 commits into from
May 24, 2020
Merged

Conversation

Joelius300
Copy link
Contributor

@Joelius300 Joelius300 commented Apr 12, 2020

This PR adds a new file with the coding conventions discussed in #58 and Joelius300/ChartJSBlazor#22. I think we should try to comply with these conventions from now on. I know that there are still lots of inconsistencies around that topic but it's time to write this stuff down and try to get more consistent at it. Maybe we'll do a big overhaul to fix it everywhere but that's a lot of work; I'm not sure if we'll do that.

You can view the file as rendered markdown (HTML) here.

I'm open for feedback and would love to hear your opinions on those conventions.

Fixes #58

Copy link
Owner

@mariusmuntean mariusmuntean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good to me. I added a question and a remark for rephrasing.

README.md Outdated Show resolved Hide resolved
Coding-conventions.md Show resolved Hide resolved
@Joelius300 Joelius300 mentioned this pull request May 24, 2020
@Joelius300 Joelius300 force-pushed the coding-conventions branch from 6977880 to 6e3fa6c Compare May 24, 2020 15:35
@Joelius300 Joelius300 merged commit 8a92281 into mariusmuntean:master May 24, 2020
@Joelius300 Joelius300 deleted the coding-conventions branch May 24, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Naming conventions discussion
2 participants