Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize kinect variables for Azure Support #67

Closed
BarusXXX opened this issue Aug 14, 2020 · 2 comments
Closed

Generalize kinect variables for Azure Support #67

BarusXXX opened this issue Aug 14, 2020 · 2 comments
Assignees
Labels
help wanted Extra attention is needed new feature Adding new functionality

Comments

@BarusXXX
Copy link
Collaborator

BarusXXX commented Aug 14, 2020

There 2 places where I could not generalize the access to kinect Type variable currently selected by the user;

Here;

protected Core.KinectTypes kinectType = Core.KinectTypes.KinectForAzureNear; //Core.KinectTypes.KinectForWindows #TODO Make more general .KinectForAzureWide

And setting the depth mode Here;

DepthMode = DepthMode.NFOV_Unbinned, //TODO Switch mode based on Azure mode WFOV_Unbinned

Using the depth mode fetching implimented here;

public static int GetDepthMode(Core.KinectTypes type)

These need to reference the active kinect type by the user.
Idea for future: We should be able to detect the kinect type currently connected, and only give the user access to different depth modes.

@BarusXXX BarusXXX changed the title Generalize options for Azure Support Generalize kinect variables for Azure Support Aug 14, 2020
@BarusXXX BarusXXX added new feature Adding new functionality help wanted Extra attention is needed labels Aug 15, 2020
BarusXXX added a commit that referenced this issue Aug 15, 2020
Latest - Missing #67
@BarusXXX
Copy link
Collaborator Author

Core.CopyAsIntArray(depthFrameData, depthFrameDataInt,

On placing the Options Component on Canvas this line active width and active height are unassigned unless default kinect is the one currently connected, we should either detect it or set it as Null as @philipbelesky suggested pausing for user input.

@BarusXXX
Copy link
Collaborator Author

BarusXXX commented Aug 16, 2020

@philipbelesky The device config needs to be reset when ever the user changes the depth mode, currently I noticed that the camera mode is not changed when the user goes from Narrow to Wide.... . From Narrow to Wide you get the out of bounds error.

ie,

  • Check if there is a camera, if so destroy it.
  • Start new camera with new settings.

BarusXXX added a commit that referenced this issue Aug 16, 2020
Hack to solve swithing repeating pattern see #67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed new feature Adding new functionality
Projects
None yet
Development

No branches or pull requests

3 participants