Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply unitsMultiplier to camera points #17

Merged

Conversation

philipbelesky
Copy link
Collaborator

The unitsMultiplier parameter was set to document units but then does not seem to have been used to scale the resulting point cloud.

There are still a few hardcoded variables that assume meters but this commit seems to get the basic dimensions scaling correctly.

Copy link
Owner

@mariuszhermansdorfer mariuszhermansdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I had it working on my local machine. Must have forgotten to update this part of code...

@mariuszhermansdorfer mariuszhermansdorfer merged commit 1e34655 into mariuszhermansdorfer:master Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants