Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MenuButton widget and basic layout for reset/calibrate buttons #98

Conversation

philipbelesky
Copy link
Collaborator

Ok, I have setup the basic layout and widget. No interactivity yet. Let me know how you feel about the style/layout

Screen Shot 2022-01-31 at 6 15 05 pm

.

@mariuszhermansdorfer
Copy link
Owner

The button looks good!

I'm not sure, whether 'reset' should be hidden in the dropdown menu, or kept as a default GH input as was the case before. It's used when users provide meshes for cut&fill calculations and as such, its functionality extends beyond just resetting the sliders to defaults.

@philipbelesky
Copy link
Collaborator Author

I think it makes sense to leave it as in input parameter. If it's used often for cut/fill it should be easier to access and might be useful to control programatically. I've reverted that in the latest commit and implemented the UI state; just need to check the actual action when I have access to a Kinect tomorrow.

@philipbelesky
Copy link
Collaborator Author

Ok, the functionality all seems to work as expected. One thing that might be good to bundle as part of the PR is to clarify the role of the Reset action with regard to Calibration and in general:

  • At the moment Calibration only begins upon Reset, is this necessary? It might be a little unintuitive.
  • Reset's tooltip states that it reverts all settings to defaults, but it acts like its more like an internal re-initialisation (e.g. buffers; sensor type; outputs) and doesn't affect the user-facing params such as columns or analysis settings. Should the help text be more oriented towards the use cases for this action?

@philipbelesky philipbelesky marked this pull request as ready for review February 2, 2022 02:28
@mariuszhermansdorfer
Copy link
Owner

Re. Calibration - now, that we have a dedicated button, calibration should be triggered by clicking on it. We only used 'reset' as a workaround.

Re. Reset functionality - the intended use was to have a 'panic button' which helps users when things go south for unknown reasons. It shouldn't reset any of the sliders' values since these are carefully chosen for given project's needs. It should, however, clear all internal buffers to hopefully fix any unexpected behavior.
Please correct the tooltip text, if you can better formulate this intention.

@philipbelesky
Copy link
Collaborator Author

Ok, great. The latest two commits decouple those two actions and attempt to clarify the help text. Should be all ready for review.

@mariuszhermansdorfer mariuszhermansdorfer merged commit 2c26a27 into mariuszhermansdorfer:feature/SandWorm2-0 Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants