Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help doesn't search when I select a quoted string #376

Closed
mark-wiemer opened this issue Aug 4, 2023 · 0 comments · Fixed by #508
Closed

Help doesn't search when I select a quoted string #376

mark-wiemer opened this issue Aug 4, 2023 · 0 comments · Fixed by #508
Assignees
Labels
enhancement new feature or request

Comments

@mark-wiemer
Copy link
Member

Description

Some selected text values don't seem to trigger search when I open help

Reproduction steps

Steps to reproduce the behavior:

  1. Select/highlight "potato" in some AHK file (including the quotes)
  2. Open help

Expected behavior

Search for "potato" is made in help

Additional context

Help opens but keeps the previous search. This is because when we try to inject "potato" into the file, we get searchText := ""potato"" which in AHK is a syntax error.

Workaround: Don't select values that start or end with ".

thqby gets around this by searching via JS. Ref #78.

@mark-wiemer mark-wiemer added the bug something isn't working label Aug 4, 2023
@mark-wiemer mark-wiemer self-assigned this Aug 4, 2023
This was referenced Aug 4, 2023
@mark-wiemer mark-wiemer added enhancement new feature or request and removed bug something isn't working labels Aug 4, 2023
mark-wiemer added a commit that referenced this issue Sep 20, 2024
mark-wiemer added a commit that referenced this issue Sep 20, 2024
@mark-wiemer mark-wiemer mentioned this issue Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant