Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comment after '#Include' not recognized as comment #86

Closed
BartmanEH opened this issue Apr 30, 2021 · 3 comments · Fixed by #297
Closed

comment after '#Include' not recognized as comment #86

BartmanEH opened this issue Apr 30, 2021 · 3 comments · Fixed by #297
Assignees
@mark-wiemer
Labels
bug something isn't working syntax highlighter syntax highlighter (code coloring) issues

Comments

@BartmanEH
Copy link

Description

a comment inserted after an Include statement is treated like a string instead of a comment:
image

Expected behavior

The comment after #Include should be syntax colored the same as other comments
@BartmanEH BartmanEH added the bug something isn't working label Apr 30, 2021
@mark-wiemer mark-wiemer added the syntax highlighter syntax highlighter (code coloring) issues label May 1, 2021
@mark-wiemer mark-wiemer added this to the Backlog milestone May 1, 2021
@mark-wiemer mark-wiemer removed this from the Backlog milestone Oct 15, 2022
mark-wiemer pushed a commit that referenced this issue Nov 18, 2022
@cweijan
Merge pull request #86 from vscode-autohotkey/fixup-linter
fd9357d 
Update linter
@kyklish kyklish mentioned this issue Dec 23, 2022
Merged
mark-wiemer pushed a commit that referenced this issue Jan 17, 2023
@kyklish
Fix include comment highlight (#297)
95d52e9 
Closes #86
@BartmanEH
Copy link
Author

gosh, almost 2 years ago... I notice this issue still persists in release v3.1.0. Do I just wait for a new release for this fix to be included?

@kyklish
Copy link
Contributor

kyklish commented Jan 18, 2023

Do I just wait for a new release for this fix to be included?

Yes, I think there will be more fixes in next release.

@mark-wiemer
Copy link
Member

Yep, this'll be fixed in the next release @BartmanEH. Thanks for your patience :)

@mark-wiemer mark-wiemer mentioned this issue Jan 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mark-wiemer mark-wiemer

Labels
bug something isn't working syntax highlighter syntax highlighter (code coloring) issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix include comment highlight kyklish/vscode-autohotkey-plus-plus
3 participants
@kyklish @BartmanEH @mark-wiemer