Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engineering #135

Merged
merged 9 commits into from
Jun 27, 2022
Merged

Engineering #135

merged 9 commits into from
Jun 27, 2022

Conversation

mark-wiemer
Copy link
Member

Closes #127.

Changes proposed in this pull request:
Various engineering hygiene fixes to improve developer experience

  • ESLint for code quality
  • Prettier for formatting
  • sort-package-json for consistency in package.json keys ordering
  • husky and lint-staged for pre-commit hooks
  • Run tests from CLI
  • validate script to automate basic checks before releasing

Replace "ISSUE" and "CHANGE" above with your values.

Do not edit below:

Notifying @mark-wiemer

From mark-wiemer/vscode-helloworld
Previously tests were modifying the `in` sample files, which needed to be manually reverted.

Now tests do not change any of the files they touch.
Remove `Getting started` as it's covered by `Contributing`
@mark-wiemer mark-wiemer merged commit db11591 into main Jun 27, 2022
@mark-wiemer mark-wiemer deleted the engineering branch June 27, 2022 02:23
@mark-wiemer mark-wiemer restored the engineering branch July 18, 2022 01:52
@mark-wiemer mark-wiemer deleted the engineering branch July 18, 2022 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use ESLint
1 participant