Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: (} else) (oneCommandCode inside legacy text) #181

Merged
merged 15 commits into from
Aug 14, 2022

Conversation

kyklish
Copy link
Contributor

@kyklish kyklish commented Jul 20, 2022

Closes #180.
Closes #188.

Changes proposed in this pull request:

  • do not clear atTopLevel flag to allow check legal one command code after braces
  • more strict regexp on detecting oneCommandCode: before it allowed only spaces or optional close bracket

Now formatter will skip legal one command code keywords in text lines

Notifying @mark-wiemer

@kyklish kyklish marked this pull request as draft July 20, 2022 20:28
@kyklish kyklish marked this pull request as ready for review July 21, 2022 15:37
@kyklish kyklish changed the title fix #180 fix #180 #188 Jul 21, 2022
@kyklish kyklish marked this pull request as draft July 21, 2022 18:19
@kyklish kyklish marked this pull request as ready for review July 21, 2022 18:39
@kyklish kyklish changed the title fix #180 #188 Fix: (} else) (oneCommandCode inside legacy text) Jul 25, 2022
@mark-wiemer mark-wiemer self-requested a review July 31, 2022 05:36
@mark-wiemer mark-wiemer self-assigned this Jul 31, 2022
mark-wiemer
mark-wiemer previously approved these changes Jul 31, 2022
Copy link
Member

@mark-wiemer mark-wiemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

# Conflicts:
#	src/test/suite/format/format.test.ts
@mark-wiemer
Copy link
Member

Happy to merge once the conflicts are resolve here, @kyklish :)

# Conflicts:
#	src/test/suite/format/format.test.ts
@kyklish
Copy link
Contributor Author

kyklish commented Aug 14, 2022

Happy to merge once the conflicts are resolve here, @kyklish :)

Done.

@mark-wiemer mark-wiemer mentioned this pull request Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants