Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to extension's settings: "Trim extra spaces between words" #191

Merged

Conversation

kyklish
Copy link
Contributor

@kyklish kyklish commented Jul 22, 2022

Closes #187.

Changes proposed in this pull request:

  • make trimming extra spaces between words optional

Notifying @mark-wiemer

@kyklish kyklish changed the title Add option to extension's settings: "Formatter: Trim extra spaces between words" Add option to extension's settings: "Trim extra spaces between words" Jul 24, 2022
@mark-wiemer mark-wiemer self-assigned this Jul 31, 2022
@mark-wiemer mark-wiemer self-requested a review July 31, 2022 05:57
Copy link
Member

@mark-wiemer mark-wiemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost ready to merge!

kyklish and others added 2 commits July 31, 2022 13:43
Co-authored-by: Mark Wiemer <7833360+mark-wiemer@users.noreply.github.com>
…es-between-words

# Conflicts:
#	src/providers/formattingProvider.ts
mark-wiemer
mark-wiemer previously approved these changes Aug 13, 2022
@mark-wiemer
Copy link
Member

Let's resolve merge conflicts and then we're good to go, @kyklish :)

…es-between-words

# Conflicts:
#	package.json
#	src/common/global.ts
#	src/providers/formattingProvider.ts
#	src/providers/formattingProvider.utils.ts
#	src/test/suite/providers/formatting/formattingProvider.utils.test.ts
@kyklish
Copy link
Contributor Author

kyklish commented Aug 14, 2022

Let's resolve merge conflicts and then we're good to go, @kyklish :)

Done.

@mark-wiemer mark-wiemer enabled auto-merge (squash) August 14, 2022 20:39
@mark-wiemer mark-wiemer merged commit 7be5de6 into mark-wiemer-org:main Aug 14, 2022
@kyklish kyklish deleted the option-not-delete-spaces-between-words branch August 15, 2022 15:22
@mark-wiemer mark-wiemer mentioned this pull request Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comments placed at end of line shifting left
2 participants