Indentation Rules

[kyklish]

Changes proposed in this pull request:

• add indentationRules to ahk.configuration.json

VS Code should adjust the indentation of current line or next line when you type, paste, and move lines.

Example:

Raw text:

var
foo() {
    if expression
        code
    code
    if (expression)
        code
    if (expression) {
        code
    }

}

RegEx capture correctly, but VS Code won't work correctly on moving line upward. Any suggestions?
Indent +

Indent -

Can't make regex case insensitive: (?i:) not work

Indentation Rules

Notifying @mark-wiemer

[mark-wiemer]

Let's merge this PR and open a couple issues: One for the fact that it doesn't work going up, and another to simplify the logic to use the same "change indentation" logic across the board. With this PR we'll have duplicated logic across the formatter and this code, won't we?

I'd still like to merge this PR as it's an improvement over the current behavior, right?

[kyklish]

Open a couple issues: One for the fact that it doesn't work going up

Agree.

Simplify the logic to use the same "change indentation" logic across the board. With this PR we'll have duplicated logic across the formatter and this code, won't we?

Not agree. Formatter can't share this code at all. It's internal VS Code implementation. Theoretically we can implement in AHK++ FormatOnType provider and do all job manually, but again, I don't see how to share code with regular formatter.

On big scripts (>1k lines) there are noticible time execution of regular formatter. It can't do it in realtime.

I'd still like to merge this PR as it's an improvement over the current behavior, right?

Yes, it's very fast realtime formatting by VS Code implementation, why not use it :)

[kyklish]

Created issue #319.

[mark-wiemer]

Sounds good, I'm still not 100% convinced we can't find some way to share this logic, but that's not a big deal. Thanks again for all your work on this project :)