Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Space key suggestion bug #110

Closed
coeyes opened this issue Sep 26, 2021 · 1 comment · Fixed by #368
Closed

Space key suggestion bug #110

coeyes opened this issue Sep 26, 2021 · 1 comment · Fixed by #368
Assignees
@mark-wiemer
Labels
bug something isn't working intellisense autocompletion, suggestions, etc.

Comments

@coeyes
Copy link

coeyes commented Sep 26, 2021 •
edited by mark-wiemer
Loading

Description

In vscode autohotkey-plus-plus,
just pushing space key suggest code completion.
this is very annoying to edit code.
In other language mode (ie: javascript), suggestion only activated when pushing non-space key or ctrl + space key.

Reproduction steps

Steps to reproduce the behavior:

  1. open any ahk file.
  2. push space

Expected behavior

  1. just pushing space should not activated suggestion.
@coeyes coeyes added the bug something isn't working label Sep 26, 2021
@mark-wiemer mark-wiemer added this to the Backlog milestone Jun 3, 2022
@mark-wiemer mark-wiemer added this to AHK++ Sep 5, 2022
@mark-wiemer mark-wiemer removed this from the Backlog milestone Oct 15, 2022
@mark-wiemer mark-wiemer added the intellisense autocompletion, suggestions, etc. label Dec 3, 2022
mark-wiemer added a commit that referenced this issue Jun 21, 2023
@mark-wiemer
Remove space from trigger char list (#110)
3606102
@mark-wiemer
Copy link
Owner

on track for closure :)

@mark-wiemer mark-wiemer mentioned this issue Jun 21, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 29, 2023
@mark-wiemer
Fixup IntelliSense-related behavior (#368)
761d758 
* Fixup typo in 3.3.0 changelog

* Remove space from trigger char list (#110)

* Remove unused code in completionProvider.ts

* Replace Method.document with Method.uriString

* Refactor completion items for methods

* Refactor `preChar` calc and add comments

* Cleanup completionProvider so it's testable

* Fix parser casing

* Document buildScript and Script

* Fixup provideCompletionItemsInner docs

* Update settings descriptions

* prefer const

* cleanup debug dispatcher start

* WIP deep pick and basic tests

* Change Omit to Pick

* Fixup completionProvider test

* Cleanup API for completion items

* Fixup types

* a

* fixup comments

* wip second test

* fixup intellisense settings

* note outer tests TBD

* Remove unnecessary async/await

* Improve docs for Method class

* Show comma-space separated params in IntelliSense

* Simplify PartialMethod type, removing DeepPick

* More tests

* Finalize provideCompletionItemsInner

* Remove console log

* Run all tests, not just new ones!

* Mark format tests for consolidation

* Fixup provideDocumentFormattingEdits unused param

* Add manual tests to repo, update demo

* fixup demos

* Add completion provider manual tests

* Change `SharpDirective` to `IfDirective` for clarity

* Fixup manual tests
@mark-wiemer mark-wiemer mentioned this issue Jul 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mark-wiemer mark-wiemer

Labels
bug something isn't working intellisense autocompletion, suggestions, etc.
Projects
AHK++
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixup IntelliSense-related behavior mark-wiemer/ahkpp
2 participants
@coeyes @mark-wiemer