Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indent after Hotkey:: and optimize #Directive code #304

Merged
merged 7 commits into from
Jan 18, 2023

Conversation

kyklish
Copy link
Contributor

@kyklish kyklish commented Dec 26, 2022

Closes #303.

Notifying @mark-wiemer

@kyklish
Copy link
Contributor Author

kyklish commented Jan 17, 2023

GitHub used to automatically merge the PR when you approve changes and I merge the main branch. Now it doesn`t do that anymore. It is a special command or default behavior?

@mark-wiemer
Copy link
Owner

GitHub used to automatically merge the PR when you approve changes and I merge the main branch. Now it doesn`t do that anymore. It is a special command or default behavior?

That's probably because I enabled auto-merge on those PRs. I forgot to do it yesterday, I'll go ahead and make sure it's set on the one's I've approved now.

@mark-wiemer mark-wiemer enabled auto-merge (squash) January 18, 2023 13:21
@mark-wiemer mark-wiemer merged commit 80d66ba into mark-wiemer:main Jan 18, 2023
@kyklish kyklish deleted the bug/fix-hotkey-up-down branch January 18, 2023 16:49
Comment on lines +1 to +2
::btw::by the way
code
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this match the expectation from the bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No indent after complex hotkey, hotstring
2 participants