Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar: Keyword #320

Merged
merged 48 commits into from
Mar 12, 2023
Merged

Grammar: Keyword #320

merged 48 commits into from
Mar 12, 2023

Conversation

kyklish
Copy link
Contributor

@kyklish kyklish commented Jan 20, 2023

Closes #318
Closes #85

Changes proposed in this pull request:

  • new regexp: make keyword bound with command

Before
Old

Now
New

Notifying @mark-wiemer

@kyklish kyklish force-pushed the bug-grammar/keyword branch from dacc55d to 0f2fafd Compare January 20, 2023 17:47
@kyklish
Copy link
Contributor Author

kyklish commented Jan 20, 2023

About ahk-explorer.ahk.snap:

  1. Switch to main branch.
  2. Run npm run test_grammar. Result is OK.
  3. Delete ahk-explorer.ahk.snap file.
  4. Generate new ahk-explorer.ahk.snap file.
  5. New file is not equal to original file.

In new file symbol \n not captured anymore.

@mark-wiemer
Copy link
Owner

Hey @kyklish , are you looking for advice here to publish this pull request?

@kyklish
Copy link
Contributor Author

kyklish commented Jan 30, 2023

Hey @kyklish , are you looking for advice here to publish this pull request?

It's "Work in progress" really. I will change PR status when it's done.

@kyklish kyklish marked this pull request as ready for review March 4, 2023 14:57
@mark-wiemer
Copy link
Owner

mark-wiemer commented Mar 6, 2023

About ahk-explorer.ahk.snap:

  1. Switch to main branch.
  2. Run npm run test_grammar. Result is OK.
  3. Delete ahk-explorer.ahk.snap file.
  4. Generate new ahk-explorer.ahk.snap file.
  5. New file is not equal to original file.

In new file symbol \n not captured anymore.

Is this issue still present?

Edit: Unable to repro, not concerned with this one. Merging :)

@mark-wiemer mark-wiemer added this pull request to the merge queue Mar 12, 2023
@mark-wiemer mark-wiemer removed this pull request from the merge queue due to a manual request Mar 12, 2023
@mark-wiemer mark-wiemer added this pull request to the merge queue Mar 12, 2023
@mark-wiemer mark-wiemer removed this pull request from the merge queue due to the queue being cleared Mar 12, 2023
@mark-wiemer mark-wiemer added this pull request to the merge queue Mar 12, 2023
Merged via the queue into mark-wiemer:main with commit c7f4e32 Mar 12, 2023
@kyklish kyklish deleted the bug-grammar/keyword branch April 1, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some variables recognized as keywords "Link" not recognized as keyword
2 participants