Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to specify a build target directory - useful if for examp… #12

Merged
merged 2 commits into from
Jun 29, 2017
Merged

Conversation

opalfroot
Copy link
Contributor

This small changes allows users to specify a build target path. I find this useful in cases where my project has many modules and I'd like to be able to specify the path of say a REST service to be rebuild and run.

…le you have a web service mixed in with other buildable code
@markbates
Copy link
Owner

How is this different from the BuildPath?

@opalfroot
Copy link
Contributor Author

opalfroot commented Jun 28, 2017

The BuildPath is where the binary goes and the BuildTargetPath is where the source resides - ie look here for buildable code.

The idea behind this is you can specify a specific package to rebuild on change and you dont need to rely on having a main somewhere at the top level. This is a likely scenario for people building cli's and web services in the same codebase using shared middle code.

@markbates
Copy link
Owner

markbates commented Jun 28, 2017

In that case, couldn't we use the AppRoot config setting instead of adding a new one?

@opalfroot
Copy link
Contributor Author

That wouldn't really work. That setting is used by the walker which needs to know about all the code you have in your project - not just the build target directory.

@markbates markbates merged commit 6796988 into markbates:master Jun 29, 2017
@markbates
Copy link
Owner

Merged! Thanks!

@opalfroot
Copy link
Contributor Author

opalfroot commented Jun 30, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants