Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
This PR addresses a few changes:
The
Generator
has been extracted out into the root of the project. This makes it clearer what is Swift Package, and what is NodeJS generation #20Remove watchOS from the structure since there is no clear and simple way to extract the bezel radius data #21
Removed the use of
txt
files and moved all data into a JSON file. This allows the data to be unique and easier to handle #24Refactored the way devices are listed in the JSON vs the CSV. JSON using the identifiers as the keys allows there to only be one key at a time - removing conflicts of duplicate identifiers #24
Fixed the way identifiers and data is moved around once the script it run #19
Refactored the modularisation of the Generator scripts #22
Issues closed
index.js
script not working #19index.js
file #22Did you test it locally?
Checklist