Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2023-09-25 - Updated package #25

Merged
merged 1 commit into from
Sep 25, 2023
Merged

2023-09-25 - Updated package #25

merged 1 commit into from
Sep 25, 2023

Conversation

markbattistella
Copy link
Owner

@markbattistella markbattistella commented Sep 25, 2023

Pull request

Description

This PR addresses a few changes:

  1. The Generator has been extracted out into the root of the project. This makes it clearer what is Swift Package, and what is NodeJS generation #20

  2. Remove watchOS from the structure since there is no clear and simple way to extract the bezel radius data #21

  3. Removed the use of txt files and moved all data into a JSON file. This allows the data to be unique and easier to handle #24

  4. Refactored the way devices are listed in the JSON vs the CSV. JSON using the identifiers as the keys allows there to only be one key at a time - removing conflicts of duplicate identifiers #24

  5. Fixed the way identifiers and data is moved around once the script it run #19

  6. Refactored the modularisation of the Generator scripts #22

Note: as for the end user / developer there are no breaking changes. There are some error handling additions, and the way the JSON is outputted, but for usage in an Xcode project the API calls are still the same

Issues closed

Did you test it locally?

  • I tested it on a local environment and it works

Checklist

  • I have performed a self-review of my own document
  • I updated the change log
  • My changes generate no new warnings
  • I have checked corrected any misspellings

@markbattistella markbattistella merged commit 23f239c into main Sep 25, 2023
1 check passed
@markbattistella markbattistella deleted the 2023.09.25 branch September 25, 2023 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant