Select JS chunk with some extra logic, fixes a bug with webpack 4 + mini-css-extract-plugin #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elying on it to be the first in the array
Add parenthesis to fix tests
jahredhope
approved these changes
Nov 19, 2018
|
Thanks for this work @Ambroos and for recreating the branch 👍 |
|
Now all we need is a release and people can switch forks back to the canonical package! Thanks! |
|
🚀Released with v3.4.2 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of #129 with merge conflicts fixed (since I no longer had access to the original repo).