Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log tests as soon as they start #1084

Closed
joshbruce opened this issue Feb 26, 2018 · 3 comments
Closed

Log tests as soon as they start #1084

joshbruce opened this issue Feb 26, 2018 · 3 comments
Labels
question RR - refactor & re-engineer Results in an improvement to developers using Marked, or end-users, or both.

Comments

@joshbruce
Copy link
Member

Marked version: 0.3.16

Proposal type: new feature

What pain point are you perceiving?

Was interacting with @davisjam on #1083 and related issues. There were two tests created for the REDOS check. I wasn't sure which test had actually experienced the DOS.

What solution are you suggesting?

I think the tests run in alphabetical order. If so, it would have been the second test that failed, not the first. Therefore, curious if we could console log as soon as the test starts - when they fail, new lines are created anyway; so, not sure the cost benefit analysis is there for have them on one line.

##. some-test
w00t!
##. some-other-test
failed

expected: ...

result: ...
##. some-ci-breaking-test

The CI service timed out
@joshbruce joshbruce added RR - refactor & re-engineer Results in an improvement to developers using Marked, or end-users, or both. question labels Feb 26, 2018
@UziTech
Copy link
Member

UziTech commented Feb 26, 2018

Would be nice to also add test time to the output. something like:

##. some-test
passed 375ms
##. some-other-test
failed 2s

@joshbruce
Copy link
Member Author

@UziTech: Nice!

Could use a second pair of eyes over on #1083 when you got a minute, if you don't have a problem with the plan. Maybe merge it in, I'll just finish off the plan.

@joshbruce
Copy link
Member Author

@davisjam did some really nice updates - think the foundations are in place once we get that merged in should just be a matter of strings and a timer??

davisjam added a commit to davisjam/marked that referenced this issue Feb 26, 2018
Problem:
On hangs, test output is hard to read.

Solution:
Print test name before starting.

Bonus:
Also print an approximation of how long each test takes to run.

For markedjs#1084.
@davisjam davisjam mentioned this issue Feb 26, 2018
7 tasks
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this issue Nov 8, 2021
Problem:
On hangs, test output is hard to read.

Solution:
Print test name before starting.

Bonus:
Also print an approximation of how long each test takes to run.

For markedjs#1084.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question RR - refactor & re-engineer Results in an improvement to developers using Marked, or end-users, or both.
Projects
None yet
Development

No branches or pull requests

2 participants