Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undeclared variable baseUrls in 0.3.9 #990

Closed
learykara opened this issue Dec 27, 2017 · 3 comments
Closed

Undeclared variable baseUrls in 0.3.9 #990

learykara opened this issue Dec 27, 2017 · 3 comments
Labels
L2 - annoying Similar to L1 - broken but there is a known workaround available for the issue

Comments

@learykara
Copy link
Contributor

Expectation

JS code builds without errors.

Result

Error is thrown by undeclared variable baseUrls.

What was attempted

On the latest version (0.3.9) it appears there is an undeclared variable baseUrls that causes an error in strict mode:

image
learykara added a commit to learykara/marked that referenced this issue Dec 27, 2017
@learykara
declare baseUrls variable
4aad0f8 
fix for markedjs#990
learykara added a commit to learykara/marked that referenced this issue Dec 27, 2017
@learykara
declare originIndependentUrl variable
2f49ab2 
fix for markedjs#990
learykara added a commit to learykara/marked that referenced this issue Dec 27, 2017
@learykara
declare undeclared variables
115b65e 
fix for markedjs#990
@learykara learykara mentioned this issue Dec 27, 2017
Merged
@DaveO-Home DaveO-Home mentioned this issue Jan 2, 2018
Closed
@joshbruce joshbruce added the L2 - annoying Similar to L1 - broken but there is a known workaround available for the issue label Jan 5, 2018
@melpon melpon mentioned this issue Jan 5, 2018
Closed
svn2github pushed a commit to svn2github/marked that referenced this issue Jan 6, 2018
declare undeclared variables
a324fbe 
fix for markedjs/marked#990

git-svn-id: https://github.com/chjj/marked.git@748 de94abd1-4c94-9ff3-2ac9-ce57b7db7bff
@yumetodo
Copy link

yumetodo commented Jan 6, 2018

Was this issue resolved by #991 ?

@joshbruce
Copy link
Member

@yumetodo: It will be, at least to the best of my knowledge. The release has not happened yet - shooting for Monday. See #1001

svn2github pushed a commit to svn2github/marked that referenced this issue Jan 9, 2018
declare undeclared variables
b6d3cb6 
fix for markedjs/marked#990

git-svn-id: https://github.com/chjj/marked.git@805 de94abd1-4c94-9ff3-2ac9-ce57b7db7bff
@Feder1co5oave
Copy link
Contributor

Fixed by #991. Close this.

zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this issue Nov 8, 2021
@learykara
declare undeclared variables
839f99d 
fix for markedjs#990
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
L2 - annoying Similar to L1 - broken but there is a known workaround available for the issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Feder1co5oave @learykara @yumetodo @joshbruce