-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bench against commonmark instead of showdown #1019
Conversation
Good call. Flagging for 0.6.0 for now. |
1e37ec7
to
bdffc69
Compare
bdffc69
to
00074d6
Compare
Recreate package-lock.json [ci skip]
Also showdown brought in a lot of (dev)dependencies that we can now drop.
|
@Feder1co5oave: Can we add the README update to this PR and then I will merge this and #1046 and publish 0.3.13 - which just leaves the lint thing over at #1020...no rush on that one. |
Sorry! Wrong button. |
@Feder1co5oave Would you like to move forward with this PR? I think it makes sense and we could also use this as a opportunity to upgrade all the versions of |
If we want to be competitive on performance nowadays, our competition is markdown-it and commonmark. Showdown is the slowest converter out there, and on my slow machine it takes a lot to bench.
I think it's pointless to compare against the notably slowest one, but we definitely should compare against commonmark. This PR does that.
See #963