Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bench against commonmark instead of showdown #1019

Merged
merged 8 commits into from
Sep 5, 2018

Conversation

Feder1co5oave
Copy link
Contributor

If we want to be competitive on performance nowadays, our competition is markdown-it and commonmark. Showdown is the slowest converter out there, and on my slow machine it takes a lot to bench.
I think it's pointless to compare against the notably slowest one, but we definitely should compare against commonmark. This PR does that.

See #963

@joshbruce joshbruce added this to the 0.6.0 - Improve developer experience milestone Jan 20, 2018
@joshbruce
Copy link
Member

Good call. Flagging for 0.6.0 for now.

@Feder1co5oave Feder1co5oave force-pushed the bench_commonmark branch 2 times, most recently from 1e37ec7 to bdffc69 Compare February 1, 2018 05:03
@Feder1co5oave Feder1co5oave mentioned this pull request Feb 2, 2018
7 tasks
@Feder1co5oave
Copy link
Contributor Author

Also showdown brought in a lot of (dev)dependencies that we can now drop.
Currently my dependency tree on my branch looks like this:

$ npm list
marked@0.3.12 /home/federico/marked
├─┬ commonmark@0.28.1
│ ├── entities@1.1.1
│ ├── mdurl@1.0.1
│ ├── minimist@1.2.0
│ └── string.prototype.repeat@0.2.0
├─┬ front-matter@2.3.0
│ └─┬ js-yaml@3.10.0
│   ├── argparse@1.0.9 deduped
│   └── esprima@4.0.0
├── glob-to-regexp@0.3.0
├─┬ markdown@0.5.0
│ └─┬ nopt@2.1.2
│   └── abbrev@1.1.1
├─┬ markdown-it@8.4.0
│ ├─┬ argparse@1.0.9
│ │ └── sprintf-js@1.0.3
│ ├── entities@1.1.1 deduped
│ ├─┬ linkify-it@2.0.3
│ │ └── uc.micro@1.0.3 deduped
│ ├── mdurl@1.0.1 deduped
│ └── uc.micro@1.0.3
└─┬ uglify-js@3.3.10
  ├── commander@2.14.1
  └── source-map@0.6.1

@joshbruce joshbruce modified the milestones: 0.6.0 - Improve developer experience, 0.4.0 - No known defects Feb 11, 2018
@joshbruce
Copy link
Member

@Feder1co5oave: Can we add the README update to this PR and then I will merge this and #1046 and publish 0.3.13 - which just leaves the lint thing over at #1020...no rush on that one.

@joshbruce joshbruce closed this Feb 11, 2018
@joshbruce joshbruce reopened this Feb 11, 2018
@joshbruce
Copy link
Member

Sorry! Wrong button.

@joshbruce joshbruce removed this from the 0.4.0 - No known defects milestone Apr 4, 2018
@styfle
Copy link
Member

styfle commented Aug 22, 2018

@Feder1co5oave Would you like to move forward with this PR?

I think it makes sense and we could also use this as a opportunity to upgrade all the versions of devDependencies since these are pretty outdated.

@styfle styfle requested a review from joshbruce August 30, 2018 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants