Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code of conduct #1094

Merged
merged 6 commits into from
Mar 8, 2018
Merged

Code of conduct #1094

merged 6 commits into from
Mar 8, 2018

Conversation

joshbruce
Copy link
Member

Marked version: 0.3.17

We're still setting up the community things related to bringing Marked back to life.

See GitHub recommendations on open source projects, specifically the CODE_OF_CONDUCT

As a contributor, what else do you think should be included here? (Use review functionality?? And comments.)

## Practices

- **Final doesn't exist:** It is assumed that each of us is working to the best of their ability to make Marked better using the knowledge and skills we each have at the time.
- **Perfection is the unattainable goal:** The long we wait to make something perfect, the longer our users have to wait for the features and functionality the want and need to be delighted with Marked. Having said that, we will always strive to continuously improve in all areass.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The long or the longer we wait?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

areass should probably be areas
Maybe run this through a spell check first.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol - Fair. Was mainly throwing it up here to see what y'all wanted to add; or, if y'all thought these were not worth having. Updated title to be more explicit of where the PR is, sorry about that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be easiest to grab an existing code of conduct and remove anything we don't agree with. That's what GitHub recommends:

Wherever you can, use prior art. The Contributor Covenant is a drop-in code of conduct that is used by over 40,000 open source projects, including Kubernetes, Rails, and Swift.
The Django Code of Conduct and the Citizen Code of Conduct are also two good code of conduct examples.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that recommendation as well - and think it may be a good one.

Under normal circumstances, I would facilitate a gathering where we actually talked about this stuff - good team building exercise - it just so happens to wind up with cultural norms at the end.

Thought this might be a good alternative and give us a chance to actually build something together as a team, which I suppose removing things might cover as well.

Which one do you think is a better for us to start with??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which of the two mentioned in the quote...??

(I also tend toward the 8fold one, which is why I picked the format, I prefer it over legalize or dry one, you know? Don't want it to be milquetoast, of course, I guess that's really up to the contributors in the end.)

Anyway...probably not focused enough on it to really take in all the potential impacts before feeling comfortable taking action.

https://8fold.pro/about

Copy link
Member

@styfle styfle Mar 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 8fold about page doesn't look like a code of conduct.
How about the node.js CODE_OF_CONDUCT.md?
It's basically copied from contributor-covenant.org.

After all, this is a project that runs on node.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the 8fold one emphasizes the concept of culture all around as opposed to "thou shalt do this and not do that". But, it could be odd for people accustomed to the other type. I do appreciate the NodeJS one and don't have anything that I would fundamentally disagree with.

@joshbruce joshbruce changed the title Code of conduct [WIP and content needed] Code of conduct Feb 28, 2018
@intcreator
Copy link

I agree with the idea of modifying an existing code of conduct. We can save time that way and get started on the long list of issues.

@joshbruce joshbruce requested review from UziTech and davisjam March 2, 2018 17:06
@joshbruce joshbruce changed the title [WIP and content needed] Code of conduct Code of conduct Mar 2, 2018
@joshbruce
Copy link
Member Author

Updated using the NodeJS base. Added section at top: Our North Star. Just a recommendation.

@styfle: Passing final decision making authority to you, brother.

version 1.4, available at [http://contributor-covenant.org/version/1/4][version]

## Appendix A: The report@nodejs.org Alias
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably remove this appendix since its specific to node

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Do you want to merge and takeover; or, I think you can work directly in the PR by hitting the "open this in GitHub Desktop"...?? Or, start a new PR and close?? I should probably catch up on the day job before they notice I'm missing...luckily they know this work is helping them too. ;)


[Moderation Policy]: https://github.com/nodejs/admin/blob/master/Moderation-Policy.md#moderation-policy
[Requesting Moderation]: https://github.com/nodejs/admin/blob/master/Moderation-Policy.md#requesting-moderation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these documents be created?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmmm...didn't notice those. If the links are there - probably - having said that, I don't know if we're that far along and I'm thinking the changes to the AUTHORS page might help?? Think they can be removed for now, to be honest.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove them

@styfle
Copy link
Member

styfle commented Mar 6, 2018

@UziTech @davisjam Any thoughts on this?

@styfle styfle merged commit d4e7bb4 into markedjs:master Mar 8, 2018
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
Add initial code of conduct similar to Node.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants