Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update authors #1101

Merged
merged 14 commits into from
Feb 28, 2018
Merged

Update authors #1101

merged 14 commits into from
Feb 28, 2018

Conversation

joshbruce
Copy link
Member

@joshbruce joshbruce commented Feb 28, 2018

Marked version: 0.3.17

Description

A lot has happened in the last couple of days that impacts the authors list...especially the fun new titles. 😝

Seriously though, for good and maybe not so good reasons.

Let me know if you don't like yours or don't really want that responsibility.

@karenyavine - Beat you to fixing the typo. Thanks for pointing it out and being willing to contribute the fix when you got a moment.

@davisjam - Welcome! Recommend checking out #1100

@intcreator - Welcome! Great questions and suggestions so far. Thank you.

Tagging @Feder1co5oave as well to close the loop on the promise made.

Contributor

  • Test(s) exist to ensure functionality and minimize regresstion (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@joshbruce joshbruce changed the title Update authors [WIP] Update authors Feb 28, 2018
Copy link
Contributor

@davisjam davisjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM haha

Copy link
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it

@joshbruce joshbruce changed the title [WIP] Update authors Update authors Feb 28, 2018
@styfle styfle merged commit 82d159a into markedjs:master Feb 28, 2018
@joshbruce joshbruce deleted the update-authors branch February 28, 2018 22:19
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants