Update readme with emoji #1207
Merged
Update readme with emoji #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Demo of this change: https://github.com/styfle/marked/blob/readme-emoji/README.md Should I update the homepage too? https://marked.js.org/#/README.md |
|
looks like the line under the Marked header passes through the logo
|
|
@UziTech Interesting. How does it look now? |
UziTech
approved these changes
Apr 6, 2018
joshbruce
reviewed
Apr 6, 2018
README.md
Outdated
| - ⚡ built for speed | ||
| - ⬇️ low-level markdown compiler for parsing without caching or blocking for long periods of time | ||
| - ⚖️ light-weight while implementing all markdown features from the supported flavors & specifications | ||
| - 🌐 works in the browser, on the server, or on the command line interface (CLI) |
There was a problem hiding this comment.
"...or through a command line interface" ??
There was a problem hiding this comment.
Here’s how I think:
- You run code in the browser
- You run code on the server
- You run code on the command line
- You run code from the command line
- You run code through a command line
I think “from” might be best here.
@UziTech Thoughts?
UziTech
reviewed
Apr 6, 2018
README.md
Outdated
| - ⚡ built for speed | ||
| - ⬇️ low-level markdown compiler for parsing without caching or blocking for long periods of time | ||
| - ⚖️ light-weight while implementing all markdown features from the supported flavors & specifications | ||
| - 🌐 works in the browser, on the server, or from the command line interface (CLI) |
There was a problem hiding this comment.
Should "the" be changed to "a"
- 🌐 works in a browser, on a server, or from a command line interface (CLI)
UziTech
approved these changes
Apr 6, 2018
|
/cc @joshbruce |
joshbruce
approved these changes
Apr 9, 2018
This was referenced Aug 30, 2019
This was referenced Oct 26, 2019
This was referenced Mar 24, 2020
This was referenced Mar 31, 2020
This was referenced Apr 7, 2020
zhenalexfan
pushed a commit
to zhenalexfan/MarkdownHan
that referenced
this pull request
Nov 8, 2021
Update readme with emoji
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🌶 Spice up the readme with emoji and logo
Contributor
Committer
In most cases, this should be a different person than the contributor.