Test folders #1213
Merged
Test folders #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UziTech
commented
Apr 10, 2018
| sanitize: false | ||
| }); | ||
| }); | ||
|
|
There was a problem hiding this comment.
We can remove this after #1212 is merged
joshbruce
reviewed
Apr 10, 2018
| @@ -169,7 +176,7 @@ describe('CommonMark 0.28 HTML blocks', function() { | |||
| var section = 'HTML blocks'; | |||
|
|
|||
| // var shouldPassButFails = []; | |||
| var shouldPassButFails = [132, 126, 147, 121, 124, 120, 153, 133, 119, 127, 117, 118, 141, 116, 158, 122, 123, 128, 143, 130, 136, 137, 140, 125, 134, 131, 144, 145, 146, 148, 139, 149, 129, 156, 135, 138, 142, 150, 151, 152, 154, 155, 157]; | |||
| var shouldPassButFails = [132, 126, 147, 124, 120, 153, 133, 119, 127, 118, 141, 116, 158, 123, 143, 130, 137, 140, 125, 134, 131, 144, 145, 148, 139, 149, 129, 156, 135, 138, 155]; | |||
|
|
|||
There was a problem hiding this comment.
What change to the lib has been made to make them pass? Honestly curious.
There was a problem hiding this comment.
I think just resetting the defaults
6 tasks
|
Who wants to do the honors? |
|
I will. Looks like we're waiting on Travis. Then we should probably head back over to #1135 to see what happened if anything. |
zhenalexfan
pushed a commit
to zhenalexfan/MarkdownHan
that referenced
this pull request
Nov 8, 2021
Test folders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked version: 0.3.19
Description
Put cm tests in spec folder
Run all tests to make sure failing tests fail
Contributor
Committer
In most cases, this should be a different person than the contributor.