Defib challenge badge #1217
Defib challenge badge #1217
Conversation
| @@ -37,7 +37,6 @@ A note on "decision making authority". This is related to submitting PRs and the | |||
| |Name |GiHub handle |Decision making |Badges of honor (tag for questions) | | |||
| |:--------------|:--------------|:----------------------------------------|------------------------------------| | |||
| |Jamie Davis |@davisjam |Seeker of Security | | | |||
| |Steven |@styfle |Open source, of course and GitHub Guru | | | |||
There was a problem hiding this comment.
Why did you remove me? Am I not allowed to review PRs?
There was a problem hiding this comment.
Of course. You were in there twice. Once in the admin section and once in the committer section. They're concentric circles. Publishers == admins == committers == contributors == users. That's why I'm not in the committers table either. :)
There was a problem hiding this comment.
Jamie and Tony aren't admins though. Make sense?
There was a problem hiding this comment.
Trust me, if it were that big of a shift...it would have been a separate PR. ;)
|
It was misleading because in the PR description there is no mention of removing a duplicate |
|
@styfle: That's fair. Will note for future. Thought the commit message would have been enough. Thanks for asking definitely see where the confusion came from. |
|
For some reason, Snyk looks stuck. Maybe the Snyk team can help use determine why this check is stuck 😅 |
|
Ok it looks like that merge fixed the Snyk check. |
|
👋 Closing and reopening the PR (or pushing a new commit) re-triggers the check and gives us a second chance to succeed. We'll take a look why that second chance was needed, thanks for bearing with us! |
Defib challenge badge
Marked version: 0.3.19
Markdown flavor: CommonMark & GitHub Flavored Markdown
Description
Adds limited badge related to the defibrillator challenge (#1216).
Contributor
Committer
In most cases, this should be a different person than the contributor.