Update majority of `original` and `new` test beds #1229

joshbruce · 2018-04-17T16:20:43Z

Marked version: 0.3.19

Markdown flavor: Markdown.pl|CommonMark|GitHub Flavored Markdown|n/a

Description

Deprecates test cases from original test suite that are covered by CommonMark and GFM test suites.
Migrates previous scenarios from the original test suite, where applicable.
Adds verifiable "Gruber" flavor where possible (original Perl).

// GFM
{
  pedantic: false,
  gfm: true
}

// CommonMark
{
  pedantic: false,
  gfm: false,
  xhtml: true,
  headerIds: false
}

// Gruber
{
  pedantic: true,
  gfm: false
}

// Issues/PRs
// For tests born from an issue or a PR, the example number will be set to the issue or PR number

Need help understanding why test exists

/new/double_link

Contributor

Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
no tests required for this PR.
If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

Draft GitHub release notes have been updated.
CI is green (no forced merge required).
Merge PR

joshbruce · 2018-04-17T16:42:48Z

Well Snyk, WIP, and review guidelines seem to work. :)

The strikethrough required GFM because strikethrough is part of that spec; chances are this will evolve over time and doesn't need to be right now.

joshbruce · 2018-04-20T23:03:13Z

This is a lot of change. I've converted and eliminated what I think is fair. Thinking we should merge this with the understanding that there will be some we might need to do differently (bringing in the full pages from Gruber) or that I need a second set of eyes on (the redos).

styfle · 2018-04-21T19:11:40Z

test/specs/commonmark/commonmark-spec.js

  });
 });

 describe('CommonMark 0.28 Fenced code blocks', function() {
  var section = 'Fenced code blocks';

  // var shouldPassButFails = [];
-  var shouldPassButFails = [93, 95, 96, 97, 101, 102, 106, 108, 111, 112, 113];
+  var shouldPassButFails = [88, 89, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 104, 105, 106, 108, 109, 110, 111, 112, 113, 115];


Why are more tests failing than before?

See testOptions. Before I turned headerIds off xhtml on...this time, I turned pedantic off, turned gfm off, headerIds off, xhtml on, and changed the value for langPrefix to match the one from the specification.

Marked doesn't really have a "CommonMark" setting or option. Those were the combination of settings that I thought would us close enough.

At least that's my best guess.

styfle · 2018-04-21T19:12:24Z

test/specs/gfm/gfm-spec.js

 describe('GFM 0.28 Tables', function() {
  var section = 'Tables';

  // TODO: Verify exmaple 193 is valid and passing
+  // var shouldPassButFails = [];


You can remove this comment

...see last reply...Someone can uncomment that one, comment out the real one, and be set to go.

styfle · 2018-04-21T19:17:21Z

test/specs/marked/marked-spec.js

+describe('Marked Issues & PRs', function() {
+  var section = 'Blockquotes';
+
+  // var shouldPassButFails = [];


Remove unused comment.

...see last reply...Someone can uncomment that one, comment out the real one, and be set to go.

styfle · 2018-04-21T19:17:30Z

test/specs/marked/marked-spec.js

+describe('Marked Issues & PRs', function() {
+  var section = 'Strikethrough';
+
+  // var shouldPassButFails = [];


Remove unused comment.

...see last reply...Someone can uncomment that one, comment out the real one, and be set to go.

styfle · 2018-04-21T19:20:26Z

test/specs/marked-tester.js

+
+MarkedTester.test = function(spec, section, ignore, options) {
+  if (spec.section === section) {
+    var shouldFail = ~ignore.indexOf(spec.example);


Have you considered moving the logic for ignore into this test() function so that each test doesn't need to concat itself (should be less prone to error).

MarkedTester.test = function(spec, section, options, shouldPassButFails, willNotBeAttemptedByCoreTeam) { var ignore = (shouldPassButFails || []).concat(willNotBeAttemptedByCoreTeam || []); // ... }

This way, the last two parameters could be optional and make each test a little smaller.

That's an interesting point and speaks a little to the "remove unused comments" reviews as well.

I'm trying to consider this as a long-term tool for others. So, each test suite is a self-contained way for someone to look and know what's going on...and easily get down to work...hence the commented out empty arrays. Someone can uncomment that one, comment out the real one, and be set to go.

Definitely, considering moving the concat step to the test though. Trying to focus on 8fold over the weekend though.

UziTech · 2019-03-12T18:26:34Z

I'm closing this in favor of #1444

Josh Bruce added 2 commits April 17, 2018 12:14

Move marked tester to module

99cb893

Confirm tabs

8f8f593

joshbruce mentioned this pull request Apr 17, 2018

[DevOps]: Node Security #1158

Closed

Josh Bruce added 25 commits April 17, 2018 12:54

New ATX heading failures discovered

4a7223c

Same Setext headings failing

5a2c671

Add new failing fenced code blocks

26019c5

Add new failures

1a94205

Add new backslash fail

a6ea9c1

Autolinks are fixed with these options

d295893

🚧 CommonMark tests converted 🚧

a97a910

🚧 GFM and Marked tests converted 🚧

08decdd

Run lint

4335296

💀Replaced by CM Autolink

6f6b552

💀Replaced by cm html blocks

03a7d92

💀Replaced by cm raw html

8f31574

💀Replaced by cm links - 523 odd man out

c3437fa

💀GFM autolinks

35fd0eb

💀Complex example replaced by various

1509a52

Migrated lazy blockquotes

31e0347

Heading IDs

4cfc1ea

Heading IDs base

34729e7

Changed my mind

ecf7ccc

The strikethrough required GFM because strikethrough is part of that spec; chances are this will evolve over time and doesn't need to be right now.

💀CM backslash escapes

2877dc9

Emphasis <= 3 chars

0856c08

Remove old em <= 3 chars

b4ac054

Nested em

a22cf5d

💀CM fenced code blocks

5efe5a6

🚩 Tildes seem inconsistent

0e8c914

joshbruce mentioned this pull request Apr 18, 2018

Inconsistent application of tildes + great combo badge #1230

Closed

Josh Bruce added 15 commits April 18, 2018 20:26

💀 Remaining tests seem overcompensation

a2e22a6

🚩 Markdown.pl prefers strong first processing unlike CM

3a58149

Marked.pl moved

80c491f

💀 CM Tabs

de52012

🚩 Not sure if Markdown.pl covered by CM

1d5ef7c

💀 CM Thematic breaks

6a3f609

💀 CM Autolinks

a04d760

💀 CM Backslash esacapes

b5b0b13

💀 CM Block quotes

214a99d

💀 CM Link reference definitions

2255457

💀 CM Code spans

868427e

💀 CM HTML blocks

979fe6d

💀 CM HTML blocks

f10a53a

💀 CM Links

449c236

💀 CM code blocks

e920300

joshbruce requested review from UziTech, styfle and davisjam April 20, 2018 23:03

Run lint

c1c2fbe

joshbruce changed the title ~~[WIP]: Update test beds with Gruber and original set~~ Update majority of original and new test beds Apr 21, 2018

styfle reviewed Apr 21, 2018

View reviewed changes

Merge branch 'master' into move-legacy-test-beds

1f98424

joshbruce mentioned this pull request Apr 26, 2018

security: finish fixing unsafe heading regex #1226

Closed

UziTech closed this Mar 12, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update majority of `original` and `new` test beds #1229

Update majority of `original` and `new` test beds #1229

joshbruce commented Apr 17, 2018 •

edited

Loading

joshbruce commented Apr 17, 2018

joshbruce commented Apr 20, 2018

styfle Apr 21, 2018

joshbruce Apr 21, 2018

joshbruce Apr 21, 2018

styfle Apr 21, 2018

joshbruce Apr 21, 2018

styfle Apr 21, 2018

joshbruce Apr 21, 2018

styfle Apr 21, 2018

joshbruce Apr 21, 2018

styfle Apr 21, 2018 •

edited

Loading

styfle Apr 21, 2018

joshbruce Apr 21, 2018

UziTech commented Mar 12, 2019

Update majority of original and new test beds #1229

Update majority of original and new test beds #1229

Conversation

joshbruce commented Apr 17, 2018 • edited Loading

Description

Need help understanding why test exists

Contributor

Committer

joshbruce commented Apr 17, 2018

joshbruce commented Apr 20, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

styfle Apr 21, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

UziTech commented Mar 12, 2019

Update majority of `original` and `new` test beds #1229

Update majority of `original` and `new` test beds #1229

joshbruce commented Apr 17, 2018 •

edited

Loading

styfle Apr 21, 2018 •

edited

Loading