-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add self from OUJS Organization to AUTHORS.md #1233
Merged
Merged
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a8dc412
Add self from OUJS Organization to AUTHORS.md
Martii 8d738ee
Add some whitespace so CSS can break some words a bit
Martii cf8d79f
Fix badge to known plays
Martii 9d5dd76
Put linkage in this header for badges
Martii 63a2981
Fix whitespace to match current .editorconfig
Martii 33ada90
Let Wikipedia decide which language to show
Martii e717846
Drop `@` symbol in our project...
Martii a961416
Refactor GFM tabling to suggested
Martii 49839e1
Trying another suggested column
Martii d95b1dc
Reorder table columns
Martii e752ed2
Don't use relative urls
Martii 955af4c
Since Project column exists remove extra text
Martii File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Martii thanks, we hadn't figured out what to do on these tables. I was thinking it would be different than the others.
Maybe:
If you would like to take the game dynamics (badges) to the OpenUserJS project right on!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks really good... plus it seems narrower for those not using the Wide GitHub Usercript by xthexder (I try to take these things into account). May put in the
@
symbol to our organization home@OpenUserJS
since the linkage is in the website.... the.org
is the project.Will change momentarily.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oooooh! That @ thing...maybe a different column?? GitHub project - a lot of our users are other open source projects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depends on how wide you want it. I use the aforementioned Userscript constantly but not everyone does so pushing the boundaries with more columns will make more word wraps. The reason I put spaces in between the
/
but didn't seem to do much. GFM can be picky sometimes.We can try it if you like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not too concerned about the width and word wraps from a PO perspective but it's a valid point. I also like the idea of linking directly to the project. Maybe something like this (adding another use to demonstrate the added value to other users:
See how some users may not have the direct one-to-one you have??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: The word wraps will potentially look and feel different here in the code review than on display on our site or by GH later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ughh GH isn't updating your comments real time... totally missed these... will read after phone call...