Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pictures to AUTHORS.md #1272

Merged
merged 10 commits into from
Jun 29, 2018
Merged

Add pictures to AUTHORS.md #1272

merged 10 commits into from
Jun 29, 2018

Conversation

styfle
Copy link
Member

@styfle styfle commented May 14, 2018

Description

This changes AUTHORS.md file so that contributor profile images are visible and also changes the order listed from most privileged to least privileged. Also the table format is a little different so that there are no columns.

This follows the format of other large open source projects such as:

Screenshot

image

Contributor

  • no tests required for this PR.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@styfle styfle added the category: docs Documentation changes label May 14, 2018
@styfle
Copy link
Member Author

styfle commented May 14, 2018

I am also thinking of changing the URL so that clicking on the profile image links to the contributors GitHub profile and clicking on their name links to their website.

@joshbruce @UziTech @davisjam Do you each have a personal website with contact info and such that you would want to link to?

Copy link
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@UziTech
Copy link
Member

UziTech commented May 15, 2018

My website is Tony.Brix.ninja

@joshbruce
Copy link
Member

We can use: https://joshbruce.com - thinking GitHub profile page might be better though...we'll sort it out if I change my mind.

@joshbruce
Copy link
Member

Will say I'm sketchy on the adding photos thing. Part of it's the designer brain I'm sure. :)

@styfle
Copy link
Member Author

styfle commented May 15, 2018

@joshbruce I added your website...now I'm concerned about nuclear warfare.
@UziTech I added your website...now I'm missing the Windows XP days.

@UziTech
Copy link
Member

UziTech commented May 15, 2018

@styfle There is no better minesweeper 😄

@joshbruce
Copy link
Member

@styfle: Sorry, this is the first chance I've had to actually look at the page. Not sure I'm digging the change in the information architecture of the page. From a UX perspective there's more cognitive load on me as a user. Can we put the images in the tables where they were...this is what groups the various users. It also makes it seem like we have a pretty large crew because all the contributors are grouped together intend of being separated.

@styfle
Copy link
Member Author

styfle commented Jun 23, 2018

@joshbruce Thanks for the feedback.
I decreased the cognitive load by decreasing the image size and getting rid of some padding.
Here's how it looks now:

image

The reason why I put all the author images next to each other is to foster a sense of community.

Keeping them separate makes it feel like we're elevating ourselves above other contributors, when the fact is, it takes a village to build OSS and all of these faces played a part in making that a reality. Let's stand together 👨‍👩‍👧‍👦


I would also like to hear feedback from others in this list such as @Feder1co5oave

@joshbruce
Copy link
Member

joshbruce commented Jun 26, 2018

Keeping them separate makes it feel like we're elevating ourselves above other contributors

Agreed. This line of thinking (invert/remove hierarchy) is actually why the straight text and table version has us below users and contributors.

Having said that, having everyone in one table also makes it seem like there are lot more of us actively maintaining or with committing then there actually are.

Can we maybe separate the table? One table for those with committer rights and then those who are classified as contributors or users.

A "committers" table, which keeps all of us together - even might be worthwhile to remove the titles as long as the separate tables still exist to help point folks to people. A "users" table that includes all the contributors to differentiate between those who are part of the core team versus those who have contributed well to the effort.

@joshbruce
Copy link
Member

ps. I do appreciate this iteration.

@davisjam
Copy link
Contributor

I have no opinion on this PR.

@styfle
Copy link
Member Author

styfle commented Jun 27, 2018

Can we maybe separate the table?

Done!

This was referenced Apr 6, 2020
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants