-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pictures to AUTHORS.md #1272
Conversation
I am also thinking of changing the URL so that clicking on the profile image links to the contributors GitHub profile and clicking on their name links to their website. @joshbruce @UziTech @davisjam Do you each have a personal website with contact info and such that you would want to link to? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
My website is Tony.Brix.ninja |
We can use: https://joshbruce.com - thinking GitHub profile page might be better though...we'll sort it out if I change my mind. |
Will say I'm sketchy on the adding photos thing. Part of it's the designer brain I'm sure. :) |
@joshbruce I added your website...now I'm concerned about nuclear warfare. |
@styfle There is no better minesweeper 😄 |
@styfle: Sorry, this is the first chance I've had to actually look at the page. Not sure I'm digging the change in the information architecture of the page. From a UX perspective there's more cognitive load on me as a user. Can we put the images in the tables where they were...this is what groups the various users. It also makes it seem like we have a pretty large crew because all the contributors are grouped together intend of being separated. |
@joshbruce Thanks for the feedback. The reason why I put all the author images next to each other is to foster a sense of community. Keeping them separate makes it feel like we're elevating ourselves above other contributors, when the fact is, it takes a village to build OSS and all of these faces played a part in making that a reality. Let's stand together 👨👩👧👦 I would also like to hear feedback from others in this list such as @Feder1co5oave |
Agreed. This line of thinking (invert/remove hierarchy) is actually why the straight text and table version has us below users and contributors. Having said that, having everyone in one table also makes it seem like there are lot more of us actively maintaining or with committing then there actually are. Can we maybe separate the table? One table for those with committer rights and then those who are classified as contributors or users. A "committers" table, which keeps all of us together - even might be worthwhile to remove the titles as long as the separate tables still exist to help point folks to people. A "users" table that includes all the contributors to differentiate between those who are part of the core team versus those who have contributed well to the effort. |
ps. I do appreciate this iteration. |
I have no opinion on this PR. |
Done! |
Add pictures to AUTHORS.md
Description
This changes
AUTHORS.md
file so that contributor profile images are visible and also changes the order listed from most privileged to least privileged. Also the table format is a little different so that there are no columns.This follows the format of other large open source projects such as:
Screenshot
Contributor
Committer
In most cases, this should be a different person than the contributor.