-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add navigation sidebar to the docs #1316
Conversation
border: 0; | ||
} | ||
.github-corner:hover .octo-arm{animation:octocat-wave 560ms ease-in-out}@keyframes octocat-wave{0%,100%{transform:rotate(0)}20%,60%{transform:rotate(-25deg)}40%,80%{transform:rotate(10deg)}}@media (max-width:500px){.github-corner:hover .octo-arm{animation:none}.github-corner .octo-arm{animation:octocat-wave 560ms ease-in-out}} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the old-school ribbon to a more modern corner that wiggles
<li><a href="#contributing">Contributing</a></li> | ||
<li><a href="#authors">Authors</a></li> | ||
<li><a href="#license">License</a></li> | ||
</ul> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need navigation in each individual file since we have a global navigation menu now.
<li><a href="#renderer">The renderer</a></li> | ||
<li><a href="#lexer">The lexer</a></li> | ||
<li><a href="#parser">The parser</a></li> | ||
</ul> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need navigation in each individual file since we have a global navigation menu now.
docs/index.html
Outdated
<div id="container"> | ||
<header> | ||
<a href="#/README.md"> | ||
<img src="img/logo-black.svg" height="64px" width="64px" /> | ||
</a> | ||
<h1>Marked.js Documentation</h1> | ||
</header> | ||
<div style="display: flex"> | ||
<nav> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We begin the new <nav>
here.
It's a sidebar on the left of the content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love it 💯 🥇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A thing of beauty.
Add navigation sidebar to the docs
Description
/docs
to be with other.md
friendsContributor
Committer
In most cases, this should be a different person than the contributor.