-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix inline code regex #1337
fix inline code regex #1337
Conversation
Which issue is this fixing? |
The slack issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I'm not confident that this change will address the Slack issue. I will ponder it tomorrow. |
When I tested this change the POC went from 9s to a few ms |
@UziTech Acknowledged. I am thinking about whether variations will still lead to the problem. |
I updated the regex to pass more of the code span spec. @davisjam check if the new regex is safe. |
I rebased and fixed the merge conflicts after #1338 |
I have reviewed the regexes. LGTM. |
Releasing |
@joshbruce I really think we should merge #1331 before a new release |
Oh. I thought it was already merged. Still good to go, yeah? (From 17 days ago, my bad.) |
Yup should be good to go |
Marked version: 0.5.0
Description
fixes #1218
Contributor
Committer
In most cases, this should be a different person than the contributor.