-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make autolinks case insensitive #1384
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styfle
reviewed
Dec 5, 2018
styfle
reviewed
Dec 5, 2018
styfle
reviewed
Dec 5, 2018
/cc @roygold7 since PR 1350 was started but didn't finish. I want to make sure Roy is aware of this PR and that the reason for the new PR is no movement on the old PR. I don't want to end up in this scenario. |
Co-Authored-By: UziTech <tony@brix.ninja>
Co-Authored-By: UziTech <tony@brix.ninja>
@styfle I appreciate the comment but I'd be just as happy if the issue was resolved in a different PR. I'm not looking for credit. |
LGTM. This should not have a ReDoS impact. |
This was referenced Aug 30, 2019
This was referenced Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked version: master
Markdown flavor: Markdown.pl|CommonMark|GitHub Flavored Markdown|n/a
Description
Make urls case insensitive
implements #1350 (comment)
Contributor
Committer
In most cases, this should be a different person than the contributor.