-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bold around autolink email address #1385
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you revert the minified file? The minified file will be automatically updated when a PR is merged.
After that it looks good to me.
Done 👌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! 🎉
Marked version: v0.5.2 (revision ed64407)
Markdown flavor: n/a
Description
__test@test.com__
This PR fixes a bug of parsing order which can lead autolink to take over parsing of other elements (e.g. bolding). Please look carefully before merging this PR: I obviously ran tests and added a new one, but this is probably a breaking change.
Also, my test should probably not be there, so please feel free to edit (I allowed edit from maintainers)(this has been fixed, c.f. my force push).Expectation
<p><strong><a href="mailto:test@test.com">test@test.com</a></strong></p>
Result
<p><a href="mailto:__test@test.co">__test@test.co</a>m__</p>
What was attempted
Reordering of parsing (autolink processing now just before text).
Contributor
Committer