-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pretty print ENOENT errors on cli #1396
Conversation
I'm not sure if this is the correct solution. It would be easier to debug with the stack trace. If we want to fix #205 we should catch that error and show a relevant message. |
could be something like marked: output to nonexistent_dir/test.html: No such directory The way this PR is right now the output would be Error: ENOENT, open 'nonexistent_dir/test.html' which is not much more helpful. |
9c7a2dd
to
8f532f0
Compare
8f532f0
to
327c9d8
Compare
@UziTech done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Marked version: master branch
Markdown flavor: n/a
Description
Hide the JS stack trace on CLI errors
Contributor
Committer
In most cases, this should be a different person than the contributor.