Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Worker thread #1428

Closed
wants to merge 5 commits into from
Closed

[WIP] Worker thread #1428

wants to merge 5 commits into from

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Feb 23, 2019

Marked version: master

Description

Use worker threads on original tests.

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@UziTech UziTech marked this pull request as ready for review February 24, 2019 05:51
@UziTech
Copy link
Member Author

UziTech commented Feb 24, 2019

Just testing out node worker threads for the "new" and "original" tests.

This will allow us to run redos tests easier.

Worker threads are experimental in node 11 so it falls back to running tests on the main thread when worker threads are not available.

I set them to fail after 2 seconds.

I also changed the tests to use Promises but everything should work in node v4 and above.

styfle
styfle approved these changes Feb 24, 2019
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@UziTech UziTech closed this Feb 27, 2019
@UziTech UziTech deleted the worker-thread branch February 27, 2019 18:00
@UziTech UziTech restored the worker-thread branch March 1, 2019 21:19
@UziTech UziTech reopened this Mar 1, 2019
@UziTech UziTech requested a review from joshbruce March 7, 2019 22:27
@UziTech UziTech changed the title Worker thread [WIP] Worker thread Mar 7, 2019
@UziTech
Copy link
Member Author

UziTech commented Mar 7, 2019

worker_threads in node are changing

We should probably wait on this until after they are not experimental.

I don't think there is a current way to move a PR back to draft.

@UziTech
Copy link
Member Author

UziTech commented Apr 25, 2019

This will be obsolete with #1482

@UziTech UziTech closed this Apr 25, 2019
@UziTech UziTech deleted the worker-thread branch July 1, 2019 18:14
@snyk-bot snyk-bot mentioned this pull request Jan 18, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@joshbruce joshbruce Awaiting requested review from joshbruce

Assignees
No one assigned
Labels
category: tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UziTech @styfle