Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass token boolean to the listitem function. #1440

Merged
merged 4 commits into from
Mar 9, 2019

Conversation

x13machine
Copy link
Contributor

@x13machine x13machine commented Mar 8, 2019

Marked version:

Markdown flavor: Markdown.pl|CommonMark|GitHub Flavored Markdown|n/a

Description

  • Passes token boolean to the listitem function. In response to this issue: Task List Classes #1430
  • Also changes "avaialable" to "available" in CONTRIBUTING.md

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

lib/marked.js Outdated Show resolved Hide resolved
Co-Authored-By: x13machine <brandanw2@gmail.com>
@x13machine
Copy link
Contributor Author

Do you think passing loose would be a good idea too?

@UziTech
Copy link
Member

UziTech commented Mar 8, 2019

Do you think passing loose would be a good idea too?

That is really only useful for telling marked how to parse text in the list item.

@styfle
Copy link
Member

styfle commented Mar 8, 2019

@x13machine Thanks for the PR!

Can you update the docs in USING_PRO.md so that listitem api matches the code?

Making a note for myself: this will be a breaking change.

@UziTech
Copy link
Member

UziTech commented Mar 8, 2019

I don't think this will be a breaking change since we are just adding parameters not changing any current parameters

@UziTech
Copy link
Member

UziTech commented Mar 8, 2019

I would say this is a minor version change, which in a beta version is the same as a patch

@styfle
Copy link
Member

styfle commented Mar 8, 2019

Oh right, we aren't changing the Renderer.prototype.listitem to depend on the new args. So I guess that's not a breaking change 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants