-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tests to node 4 syntax #1449
Conversation
test/helpers/helpers.js
Outdated
} | ||
result.message = 'Expected:\n' + expectedHtml + '\n\nActual:\n' + actualHtml; | ||
const diff = htmlDiffer.firstDiff(actual, expected); | ||
result.message = 'Expected: ' + diff.expected + '\n Actual: ' + diff.actual; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
result.message = 'Expected: ' + diff.expected + '\n Actual: ' + diff.actual; | |
result.message = `Expected: ${expected}\nActual: ${actual}`; |
test/index.js
Outdated
@@ -289,13 +245,13 @@ function runBench(options) { | |||
} | |||
bench('marked (pedantic)', files, marked); | |||
|
|||
// showdown | |||
// commonmark |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove these comments since they are redundant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
Marked version: master
Description
Update all tests to use html-differ and use syntax for node 4
Contributor
Committer
In most cases, this should be a different person than the contributor.