Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix image parentheses #1557

Merged
merged 1 commit into from
Oct 3, 2019
Merged

fix image parentheses #1557

merged 1 commit into from
Oct 3, 2019

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Oct 3, 2019 •
edited
Loading

Marked version: 0.7.0

Description

Fix image surrounded by parentheses

fixes #1556

demo works in v0.6.3 but not v0.7.0

Contributor

  • Test(s) exist to ensure functionality and minimize regression

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@vercel
Copy link

vercel bot commented Oct 3, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://markedjs-git-fork-uzitech-image-paren.markedjs.now.sh

@UziTech UziTech mentioned this pull request Oct 3, 2019
Closed
styfle
styfle approved these changes Oct 3, 2019
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@joshbruce joshbruce merged commit 1b08126 into markedjs:master Oct 3, 2019
@UziTech UziTech deleted the image-paren branch December 4, 2019 16:17
@UziTech UziTech mentioned this pull request Dec 4, 2019
Merged
12 tasks
This was referenced Dec 20, 2019
Open
Open
Open
Merged
Closed
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@ManPrivate ManPrivate mentioned this pull request Oct 27, 2024
Open
@tdsnyk tdsnyk mentioned this pull request Oct 28, 2024
Open
@sri-sankari sri-sankari mentioned this pull request Oct 28, 2024
Open
@mohankumar931 mohankumar931 mentioned this pull request Oct 28, 2024
Open
@foolcardssk foolcardssk mentioned this pull request Oct 29, 2024
Open
@arunnsm arunnsm mentioned this pull request Oct 29, 2024
Open
@sound25 sound25 mentioned this pull request Oct 29, 2024
Open
@Latha-lgtm Latha-lgtm mentioned this pull request Oct 29, 2024
Open
@GOWTHAMAKURINJIVEANDAN GOWTHAMAKURINJIVEANDAN mentioned this pull request Oct 29, 2024
Open
@Dejah2024 Dejah2024 mentioned this pull request Oct 30, 2024
Open
@ThiruVaithiya ThiruVaithiya mentioned this pull request Oct 30, 2024
Open
@Upender5119 Upender5119 mentioned this pull request Oct 30, 2024
Open
@Suriya0802 Suriya0802 mentioned this pull request Oct 30, 2024
Open
@Shriv12 Shriv12 mentioned this pull request Oct 30, 2024
Open
@Magali0007 Magali0007 mentioned this pull request Oct 31, 2024
Open
@sureshrtech1 sureshrtech1 mentioned this pull request Oct 31, 2024
Open
@Praganya03 Praganya03 mentioned this pull request Oct 31, 2024
Open
@Ganesh13349 Ganesh13349 mentioned this pull request Oct 31, 2024
Open
@robertnorrie robertnorrie mentioned this pull request Oct 31, 2024
Open
@sinnakkrishnan sinnakkrishnan mentioned this pull request Nov 1, 2024
Open
@Vijay-2302 Vijay-2302 mentioned this pull request Nov 1, 2024
Open
@krithika-manohar krithika-manohar mentioned this pull request Nov 1, 2024
Open
@SAGAYANELSON55 SAGAYANELSON55 mentioned this pull request Nov 1, 2024
Open
@swathi-ra swathi-ra mentioned this pull request Nov 2, 2024
Open
@austinskou austinskou mentioned this pull request Nov 3, 2024
Open
@BD-HUGO BD-HUGO mentioned this pull request Nov 3, 2024
Open
@danielsb74 danielsb74 mentioned this pull request Nov 5, 2024
Open
@selvaganesh26 selvaganesh26 mentioned this pull request Nov 5, 2024
Open
@merkeldev merkeldev mentioned this pull request Nov 5, 2024
Open
@joedean-git joedean-git mentioned this pull request Nov 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshbruce joshbruce joshbruce approved these changes

@styfle styfle styfle approved these changes

@davisjam davisjam Awaiting requested review from davisjam

Assignees
No one assigned
Labels
category: images
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue #1456 has returned
3 participants
@UziTech @styfle @joshbruce