Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Babel's loose mode for shorted & more performant code #1572

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

Andarist
Copy link
Contributor

@Andarist Andarist commented Dec 4, 2019

The premise is here that this should be slightly faster and certainly is slightly more lightweight. This sacrifices spec-correctness (not needed for the majority of use cases).

@vercel
Copy link

vercel bot commented Dec 4, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/markedjs/markedjs/87i679vyj
🌍 Preview: https://markedjs-git-fork-andarist-enable-loose-mode.markedjs.now.sh

Copy link
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 I like it. Smaller file size and easier to read.

@UziTech UziTech requested review from joshbruce and styfle December 4, 2019 17:01
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me

@UziTech UziTech merged commit 2df8c4a into markedjs:master Dec 5, 2019
@UziTech UziTech mentioned this pull request Dec 5, 2019
12 tasks
This was referenced Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants