-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove incorrectly used browser field #1573
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/markedjs/markedjs/hetghzz43 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This is a common misconception - but browser field is not for pointing to a fully browser-compatible file (like in your case you have wanted to point with it to the UMD bundle). It exists to alias files depending on node-specific modules/APIs to files that can be used in browsers (so for example with node-specific modules/APIs stubbed) after bundling etc.
For example webpack picks "browser" field over "module" by default if provided and that kinda makes "module" file not-used - but the intention is to actually use it.
As you don't depend on any node-specific stuff the appropriate course of action is to just remove this field from your package.json