Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrectly used browser field #1573

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

Andarist
Copy link
Contributor

@Andarist Andarist commented Dec 4, 2019

This is a common misconception - but browser field is not for pointing to a fully browser-compatible file (like in your case you have wanted to point with it to the UMD bundle). It exists to alias files depending on node-specific modules/APIs to files that can be used in browsers (so for example with node-specific modules/APIs stubbed) after bundling etc.

For example webpack picks "browser" field over "module" by default if provided and that kinda makes "module" file not-used - but the intention is to actually use it.

As you don't depend on any node-specific stuff the appropriate course of action is to just remove this field from your package.json

@vercel
Copy link

vercel bot commented Dec 4, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/markedjs/markedjs/hetghzz43
🌍 Preview: https://markedjs-git-fork-andarist-remove-browser-field.markedjs.now.sh

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@UziTech UziTech merged commit 81d3018 into markedjs:master Dec 5, 2019
@UziTech UziTech mentioned this pull request Dec 5, 2019
12 tasks
This was referenced Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants